Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps versions of several runtime dependencies and devDependencies in package.json (and syncs pnpm-lock.yaml) to newer minor/patch releases for the app SDK, UI kit, Sentry, React Query, DOM-related libs, TypeScript toolchain, Jest environment, Vite, and SWC tooling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- You’re updating
jest-environment-jsdomto v30.x while keepingjestandts-jeston v29.x; it’s worth aligning the Jest-related packages to the same major version to avoid subtle runtime or configuration incompatibilities.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You’re updating `jest-environment-jsdom` to v30.x while keeping `jest` and `ts-jest` on v29.x; it’s worth aligning the Jest-related packages to the same major version to avoid subtle runtime or configuration incompatibilities.
## Individual Comments
### Comment 1
<location> `package.json:56` </location>
<code_context>
"intersection-observer": "^0.12.2",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "3.2.4",
"react-resize-observer": "^1.1.1",
</code_context>
<issue_to_address>
**issue (bug_risk):** Version mismatch between Jest core (29.x) and jest-environment-jsdom (30.x) may be unsupported.
Using `jest-environment-jsdom@30.x` with `jest@29.7.0` is likely an unsupported combination and may cause subtle test issues. Please either keep `jest-environment-jsdom` on 29.x or upgrade Jest to 30.x so the major versions match.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request updates multiple dependencies and devDependencies to their latest versions, including core libraries like @deskpro/app-sdk, @sentry/react, @tanstack/react-query, and development tools like typescript, vite, and testing utilities. These updates aim to ensure compatibility, security, and access to the latest features and bug fixes.
Key Changes:
- Core library updates: Deskpro SDK, UI libraries, Sentry, React Query, DOM utilities
- Development tooling updates: TypeScript 5.9.3, Vite 6.4.1, SWC compiler, testing libraries
- Type definition updates for React and related packages
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency versions for both production and development packages |
| pnpm-lock.yaml | Auto-generated lockfile reflecting the dependency updates and their transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies and devDependencies in the
package.jsonfile to newer versions. These updates include both core libraries and development tools, which should help ensure compatibility, security, and access to the latest features and bug fixes.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query,dompurify,immer,react-router-dom, andstyled-componentsto their latest minor or patch versions.Development tool updates:
@swc/core,@swc/helpers,@testing-library/jest-dom,@types/react,@vitejs/plugin-react,jest-environment-jsdom,ts-jest,typescript, andviteto newer versions for improved tooling and compatibility.Summary by Sourcery
Update application and tooling dependencies to newer minor and patch versions for compatibility, security, and maintenance.
Enhancements:
Build:
Chores: